Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed electron drift electrons starting at z > -1 cm #296

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sebvetter
Copy link
Contributor

What does the code in this PR do / what does it improve?

The default field distortion map only extends up to z = -1 cm, afterwards it extrapolates. Electrons at the very top of the TPC do not drift and need to field distortion. Therefore I removed the application of the FDC for z > -1 cm.

Can you briefly describe how it works?

Make a selection of events with z < -1cm and apply the field distortion on the selected events (instead of all).

Can you give a minimal working example (or illustrate with a figure)?

electron_drift_use_fdc_for_top
Before the fix: The position in the instructions and the position at the interface are not the same because of electron drift.

electron_drift_no_fdc_for_top
After the fix: The instructed position and the interface position are the same (only electrons starting at z = -0.1cm shown).

Please include the following if applicable:

  • Update the docstring(s)
  • Bump plugin version(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the GitHub open issues?

Sorry, something went wrong.

@coveralls
Copy link

coveralls commented Mar 4, 2025

Pull Request Test Coverage Report for Build 13653280447

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 79.981%

Totals Coverage Status
Change from base Build 13387532307: 0.02%
Covered Lines: 2537
Relevant Lines: 3172

💛 - Coveralls

@sebvetter sebvetter self-assigned this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants