This repository was archived by the owner on Jun 5, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
Strax interface plugin implements its own configuration management, bypassing the strax config management. This results in many hacks and unneeded complexity when generating the strax context. I assume this was done because of the large number of config options and their historical loading from config files.
The overlapping of config names between fax configuration and straxen processing plugins (for obvious reasons) creates two main issues:
This PR is an experiment on whether we can use strax config management for all fax configs and remove the
set_config()
method.The implementation is still a work in progress, it may take some time to get a working prototype.