Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the MisIdS1SingleScatter cut, specifically for SR2 but also for SR1.
I'm not sure what the best way to organize this is so if anyone thinks we should not add this cut to e.g.
sciencerun0.py
orsciencerun1.py
please let me know.The note for the update can be found here. The cut is improved for both SR1 and SR2, where pax v6.10.1 data was used.
I also compared the cut with the similar KryptonMisIdS1, where I found that the latter removes a subset of those removed by MisIdS1SingleScatter, but doesn't remove all the events that it should. I think we should merge these two cuts, but also wanted to keep some type of backwards compatibility, so I just set the cuts equal in the sciencerun1 and sciencerun2 files. I left sciencerun0.py in case anyone wants to use the old cut.
Finally, this PR removes the MisIdS1SingleScatter cut previously defined in
postsr1.py
. Again, please let me know if a different organization is preferred.