Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kr83mcut #168

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Kr83mcut #168

wants to merge 3 commits into from

Conversation

ershockley
Copy link
Contributor

This PR updates the MisIdS1SingleScatter cut, specifically for SR2 but also for SR1.

I'm not sure what the best way to organize this is so if anyone thinks we should not add this cut to e.g. sciencerun0.py or sciencerun1.py please let me know.

The note for the update can be found here. The cut is improved for both SR1 and SR2, where pax v6.10.1 data was used.

I also compared the cut with the similar KryptonMisIdS1, where I found that the latter removes a subset of those removed by MisIdS1SingleScatter, but doesn't remove all the events that it should. I think we should merge these two cuts, but also wanted to keep some type of backwards compatibility, so I just set the cuts equal in the sciencerun1 and sciencerun2 files. I left sciencerun0.py in case anyone wants to use the old cut.

Finally, this PR removes the MisIdS1SingleScatter cut previously defined in postsr1.py. Again, please let me know if a different organization is preferred.

@JelleAalbers
Copy link
Contributor

Hi Evan, I have a conference this week, but perhaps someone else is available to review this. Otherwise I could do so next week (someone may have to remind me :-))

@JelleAalbers
Copy link
Contributor

Hi Evan, thanks for this change. We currently only put cuts that were used for the frozen tonne-year paper analysis in the sciencerun0 and sciencerun1 lichen files. See the 'code organization' section of the readme on the main page.

So I think the MisIdS1SingleScatter cut was fine were it was (postsr1, since it applies to SR1 but is from a post-tonne-year analysis) and your new cut can be there as well, if it applies to SR1 and SR2. Then you can reference it in sciencerun2.py. Alternatively you could define it in sciencerun2 and then reference it in postsr1; up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants