Mark autocomplete #377
Mark autocomplete #377
Conversation
|
nice, could you resolve conflicts? will test it out sometime when i get a chance! |
src/assets/ts/components/line.tsx
Outdated
| wordHook?: PartialUnfolder<Token, React.ReactNode>; | ||
| onCharClick?: ((col: Col, e: Event) => void) | undefined; | ||
| cursorBetween?: boolean; | ||
| session?: Session; |
There was a problem hiding this comment.
might be better to not have the Session abstraction here and just pass in something like
renderLineAnnotationHook?: (info: { lineData: .., column: ..., cursors: ...}) => Array<React.ReactNode>,
There was a problem hiding this comment.
I got it working that way, but I had to bind the session to the function. Does that defeat the purpose? Genuinely curious exactly why this way is cleaner.
There was a problem hiding this comment.
yeah, fine to bind the session to the function from the caller. i don't know if it really matters, was just going broadly by the principle of requiring less abstractions in interfaces :)
for example if you wrote a unit test for line.tsx it would be maybe annoying if you had to construct a session object to test
There was a problem hiding this comment.
makes sense, thanks for explaining!
|
I think it will be better to implement this as a mode, will update this later |
2 participants
Adds an autocomplete menu when creating mark links. Navigate with up, down, and enter.