Skip to content

Fix async redirect handling regression from FOLLOW_REDIRECTS default#1315

Closed
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/critical-bug-fixes-bc3a
Closed

Fix async redirect handling regression from FOLLOW_REDIRECTS default#1315
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/critical-bug-fixes-bc3a

Conversation

@cursor

@cursor cursor Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Restore async-mode default that disables automatic HTTP redirect following unless FOLLOW_REDIRECTS is explicitly set.

Fixes

  • Async connectors (e.g. Slack Analytics) that rely on intercepting 3xx responses to fetch pre-signed download URLs

Bug and impact

Commit #1278 introduced FOLLOW_REDIRECTS but changed the default from !processingContext.getAsync() to true. Async connectors without an explicit FOLLOW_REDIRECTS=FALSE env var (Slack Analytics has empty environment_variables) now have the HTTP client follow redirects transparently. The proxy never sees the 3xx + Location header, so the async redirect-handling block in ApiDataRequestHandler is bypassed and sanitized data is not written to the async output bucket.

Root cause

ApiDataRequestHandler defaulted setFollowRedirects(true) when FOLLOW_REDIRECTS is unset, replacing the prior behavior that disabled redirect following in async mode.

Fix and validation

  • Restore default: orElse(!processingContext.getAsync())
  • Update ProxyConfigProperty javadoc to document the async/sync default split
  • Add asyncModeDisablesRedirectFollowingByDefault unit test
  • Ran mvn -pl core -am test -Dtest=ApiDataRequestHandlerTest#asyncModeDisablesRedirectFollowingByDefault,ApiDataRequestHandlerTest#handleShouldFollowRedirectManuallyInAsyncMode

Change implications

  • dependencies added/changed? no
  • something important to note in future release notes?
    • Fixes Slack Analytics async file downloads on v0.6.6 when FOLLOW_REDIRECTS is not explicitly configured
    • breaking changes? no
Open in Web View Automation 

Commit #1278 changed redirect following to default true unless
FOLLOW_REDIRECTS is explicitly set. That broke async connectors (e.g.
Slack Analytics) which rely on intercepting 3xx responses when
FOLLOW_REDIRECTS is not configured.

Restore the prior default: do not follow redirects in async processing
unless FOLLOW_REDIRECTS is explicitly set. Add a unit test that locks
in the behavior.

Co-authored-by: Erik Schultink <eschultink@users.noreply.github.com>
@eschultink eschultink closed this Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants