misc v0.6.7 fixes#1313
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts Terraform modules/tests for the misc v0.6.7 release, primarily to stop implicitly granting the Psoxy caller access to lookup-table output buckets (leaving that access decision to customers), along with minor Terraform formatting cleanups.
Changes:
- AWS host module: exclude lookup-table output buckets from the consolidated caller read-access policy inputs.
- Terraform formatting updates in GCP Cloud Functions modules (secret env var
keyassignment) and related.tftest.hclfiles. - Terraform formatting updates in AWS module test variables.
Reviewed changes
Copilot reviewed 1 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| infra/modules/gcp-webhook-collector/main.tf | Terraform formatting tweak in secret_environment_variables block. |
| infra/modules/gcp-webhook-collector/ip_lock_conditions.tftest.hcl | Terraform test variable formatting cleanup. |
| infra/modules/gcp-proxy-bulk/main.tf | Terraform formatting tweak in secret_environment_variables block. |
| infra/modules/gcp-proxy-api/main.tf | Terraform formatting tweak in secret_environment_variables block. |
| infra/modules/aws-proxy-bulk/provision_testing_infra.tftest.hcl | Terraform test variable formatting cleanup. |
| infra/modules/aws-host/main.tf | Removes lookup-table buckets from inputs used to grant the caller read access. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
501
to
505
| [for k, v in module.bulk_connector : v.sanitized_bucket], | ||
| [for k, v in module.webhook_collectors : v.output_sanitized_bucket_id], | ||
| [for k, v in module.api_connector : v.async_output_bucket_id if try(v.async_output_bucket_id, null) != null], | ||
| [for k, v in module.api_connector : v.side_output_sanitized_bucket_id if try(v.side_output_sanitized_bucket_id, null) != null], | ||
| [for k, v in module.lookup_output : v.output_bucket], | ||
| ))) |
jlorper
approved these changes
Jun 19, 2026
aperez-worklytics
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Change implications
terraform plan/apply.