Fix async error output and release verifier syntax#1263
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Erik Schultink <eschultink@users.noreply.github.com>
Co-authored-by: Erik Schultink <eschultink@users.noreply.github.com>
Co-authored-by: Erik Schultink <eschultink@users.noreply.github.com>
An error occurred while trying to automatically change base from
rc-v0.6.3
to
main
June 8, 2026 17:34
eschultink
reviewed
Jun 16, 2026
| ProcessingContext processingContext) throws IOException { | ||
| if (!processingContext.getAsync()) { | ||
| return response; | ||
| } |
Member
There was a problem hiding this comment.
very unuseful encapsulation, imho.
eschultink
reviewed
Jun 16, 2026
| return response; | ||
| } | ||
|
|
||
| private void writeAsyncErrorContent(ProcessedContent content, String errorCause, |
Member
There was a problem hiding this comment.
split of this and method above seems like poor code style; just unnecessary complexity.
| builder.body("Error communicating with source API: " + e.getMessage()); | ||
| log.log(Level.SEVERE, "Error communicating with source API", e); | ||
| return builder.build(); | ||
| return writeAsyncErrorResponseIfNeeded(builder.build(), processingContext); |
Member
There was a problem hiding this comment.
seems weird to call build() here - not just pass the builder ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two high-severity correctness defects found while reviewing recent release-window changes.
Fixes
202 Accepteddo not poll an empty output location indefinitely.}preventedtools/release/verify-bundles.shfrom running at all.Features
Logistics
Change implications
ErrorandPsoxy-Versionmetadata when source/redirect processing fails.Validation performed:
bash -n tools/release/lib/verify-bundles-lib.sh && bash -n tools/release/verify-bundles.sh && ./tools/release/verify-bundles.sh --helpmvn -pl core -am -Dtest=ApiDataRequestHandlerTest -Dsurefire.failIfNoSpecifiedTests=false testmvn -pl core -am test