Skip to content

S219 : prep next version #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlorper merged 4 commits into from
Feb 27, 2026
Merged

S219 : prep next version #93

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e46e5e
bump version number; delete old pom
eschultink Feb 25, 2026
c4a0933
bump to java21
eschultink Feb 25, 2026
44771b0
cleanup workflow
eschultink Feb 25, 2026
8b20580
organize dependencies
eschultink Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test-java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: 'adopt'
java-version: '17' # maven won't accept --release argument with java < 8; and 11 is next LTS
java-version: '21' # maven won't accept --release argument with java < 8; and 11 is next LTS

Copilot AI Feb 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline comment about the Java version is outdated/misleading now that this is set to 21 (e.g., it mentions Java 11 being the next LTS and discusses --release, which this workflow doesn't use). Please update or remove the comment to reflect the current setup.

Copilot uses AI. Check for mistakes.
- id: 'read-cache-maven-packages'
name: Read Cached Maven packages
uses: actions/cache@v4
Expand Down Expand Up @@ -56,7 +56,7 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: 'adopt'
java-version: '17' # maven won't accept --release argument with java < 8; and 11 is next LTS
java-version: '21' # maven won't accept --release argument with java < 8; and 11 is next LTS
Comment on lines 58 to +59

Copilot AI Feb 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline comment about the Java version is outdated/misleading now that this is set to 21 (e.g., it mentions Java 11 being the next LTS and discusses --release, which this workflow doesn't use). Please update or remove the comment to reflect the current setup.

Copilot uses AI. Check for mistakes.
- id: 'read-cache-maven-packages'
name: Read Cached Maven packages
uses: actions/cache@v4
Expand Down
258 changes: 0 additions & 258 deletions java/appengine-pipeline-0.3+worklytics.12-pom.xml
View file
Open in desktop

This file was deleted.

7 changes: 3 additions & 4 deletions java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</license>
</licenses>
<properties>
<revision>0.3+worklytics.12</revision>
<revision>0.3+worklytics.13</revision>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<jackson.version>[2.18.2, 2.18.3)</jackson.version> <!-- 2.18.2+ (stable) -->
<dagger.version>2.55</dagger.version> <!-- 2.55+ adds support for injecting jakarta.inject.Provider -->
Expand All @@ -41,9 +41,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.13.0</version>
<configuration>
<source>17</source>
<target>17</target>

<source>21</source>
<target>21</target>
Comment on lines +44 to +45

Copilot AI Feb 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the maven-compiler-plugin <release>21</release> setting instead of <source>/<target>. <release> ensures the correct JDK API level is used during compilation (and avoids accidental linkage against newer JDK classes when building on newer toolchains).

Suggested change
<source>21</source>
<target>21</target>
<release>21</release>

Copilot uses AI. Check for mistakes.
</configuration>
Comment on lines -39 to 59

Copilot AI Feb 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description mentions "new mvn plugins", but the only Maven-related change in this diff is updating compiler source/target to 21. If additional plugin updates were intended, they may be missing from the PR description or from the actual changes—please align the description with what’s being shipped.

Copilot uses AI. Check for mistakes.
</plugin>
<plugin>
Expand Down