Skip to content

Conversation

@RayRedGoose
Copy link
Contributor

Issue

Summary

Fix deprecation label in objects

Release Category

Infrastructure


Where Should the Reviewer Start?

Testing Manually

Thank You GIF

Copilot AI review requested due to automatic review settings January 8, 2026 17:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the handling of deprecation labels in TypeScript type definition objects by updating the JSDoc generator to properly extract and display @deprecated tags from token metadata.

Key Changes:

  • Thread allTokens array through the formatter to enable lookup of original token metadata including deprecation information
  • Extract deprecated and deprecatedComment fields from token original metadata and generate @deprecated JSDoc tags
  • Adjust JSDoc formatting to accommodate deprecation labels with additional blank lines

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
packages/canvas-tokens/utils/formatters/formatTypes.ts Added allTokens parameter threading and token lookup logic; enhanced JSDoc generation to include deprecation tags
packages/canvas-tokens/utils/spec/formats.spec.ts Updated test expectation to reflect additional blank JSDoc lines in output

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RayRedGoose RayRedGoose added the automerge Automatically merge pull request label Jan 8, 2026
@RayRedGoose RayRedGoose merged commit fd7e357 into prerelease/major Jan 8, 2026
16 checks passed
@RayRedGoose RayRedGoose deleted the fix-system-tokens-deprecation branch January 8, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants