-
Notifications
You must be signed in to change notification settings - Fork 245
docs: Migrating accessibility guidelines for FormFIeld, TextInput, TextArea #3615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
williamjstanton
wants to merge
14
commits into
Workday:master
Choose a base branch
from
williamjstanton:william-docs-form-fields
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f3f32dd
docs: Accessibility for FormField and TextInput
2b90c75
docs: Deleting Error & Caution from TextInput
c4caafd
docs: Accessibility for TextArea
8e88127
docs: Creating new TextArea example
2d7dc9e
docs: Reorganizing & adding docs to MDX
a5e7311
docs: Refactoring InputGroup examples
171cb62
Merge branch 'master' into william-docs-form-fields
9f8051d
docs: Fixing Cypress test errors
3c48cf8
Apply suggestions from code review
williamjstanton 5cacee5
docs: Fixing Storybook links
0e16a15
Merge branch 'master' into william-docs-form-fields
f204d11
Merge branch 'master' into william-docs-form-fields
mannycarrera4 68bf901
test: Update check for test
4da4baf
Merge branch 'master' into william-docs-form-fields
mannycarrera4 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
52 changes: 52 additions & 0 deletions
52
modules/docs/mdx/accessibility/examples/AriaLiveRegions/CommentBoxWithCharLimit.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| import React from 'react'; | ||
| import {FormField} from '@workday/canvas-kit-react/form-field'; | ||
| import {TextArea} from '@workday/canvas-kit-react/text-area'; | ||
| import {AriaLiveRegion, AccessibleHide} from '@workday/canvas-kit-react/common'; | ||
|
|
||
| const MAX_CHARACTERS = 200; | ||
| const DEBOUNCE_DELAY = 2000; // 2 seconds after user stops typing | ||
|
|
||
| export const CommentBoxWithCharLimit = () => { | ||
| const [value, setValue] = React.useState(''); | ||
| const [liveUpdateStr, setLiveUpdateStr] = React.useState(''); | ||
| const hintTextStr = `${value.length} of ${MAX_CHARACTERS} characters`; | ||
|
|
||
| const handleChange = (event: React.ChangeEvent<HTMLTextAreaElement>) => { | ||
| setValue(event.target.value); | ||
| }; | ||
|
|
||
| const handleBlur = () => { | ||
| setLiveUpdateStr(''); | ||
| }; | ||
|
|
||
| React.useEffect(() => { | ||
| // Immediately announce when limit is reached (bypass debounce) | ||
| if (value.length === MAX_CHARACTERS) { | ||
| setLiveUpdateStr(`Character limit reached. ${value.length} of ${MAX_CHARACTERS} characters`); | ||
| return; | ||
| } | ||
|
|
||
| // Otherwise, debounce the updates | ||
| const timer = setTimeout(() => { | ||
| setLiveUpdateStr(hintTextStr); | ||
| }, DEBOUNCE_DELAY); | ||
| return () => clearTimeout(timer); | ||
| }, [hintTextStr]); | ||
|
|
||
| return ( | ||
| <FormField> | ||
| <FormField.Label>Comments</FormField.Label> | ||
| <FormField.Field> | ||
| <FormField.Input | ||
| as={TextArea} | ||
| onChange={handleChange} | ||
| onBlur={handleBlur} | ||
| value={value} | ||
| maxLength={MAX_CHARACTERS} | ||
| /> | ||
| <FormField.Hint>{hintTextStr}</FormField.Hint> | ||
| <AriaLiveRegion as={AccessibleHide}>{liveUpdateStr}</AriaLiveRegion> | ||
| </FormField.Field> | ||
| </FormField> | ||
| ); | ||
| }; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.