65443 - Add a cleanup function under unzip file tests.

[aslamdoctor]

Trac ticket: https://core.trac.wordpress.org/ticket/63443

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props aslamdoctor, sirlouen.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[SirLouen]

@aslamdoctor
Looks good to me.
But I think it will be better to add cleanup_unzip_destination to tests/phpunit/includes/abstract-testcase.php (always try to DRY)

[SirLouen]

I would add a reference here to the ticket.
Something like

// See #65443 for details

[SirLouen]

Ok, now things are looking good, but it seems that two tests are still failing:

1) Tests_Filesystem_UnzipFilePclzip::test_should_apply_pre_unzip_file_filters
mkdir(): File exists

/var/www/tests/phpunit/tests/filesystem/unzipFilePclzip.php:44

ERRORS!
Tests: 4, Assertions: 3, Errors: 1.

Because we forgot to add the cleanup_unzip_destination in the method test_should_apply_pre_unzip_file_filters.
for both: tests/phpunit/tests/filesystem/unzipFileZiparchive.php
And: tests/phpunit/tests/filesystem/unzipFilePclzip.php

Finally, for PHPCS compliance: Inline comments must end in full-stops, exclamation marks, or question marks
(Just add a full stop by the end of each comment, like: // See #65443 for details.

And with this, I think we are done.

[SirLouen]

74 | ERROR   | Inline comments must end in full-stops, exclamation marks, or question marks