Try using popover API for image lightbox #68726
Draft
+70
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +175 B (+0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
Flaky tests detected in cabba6d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12819863388
|
Why, because of Kses? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative to #68725, this PR explores using the
popoverAPI for the image lightbox instead of a regular less semanticdiv.Benefits:
z-indexnecessary (top-level is higher than anyz-indexcan be).::backdroppseudo element that can be styled.Escapeautomatically closes the lightbox.Caveats:
popovertargetattribute, so requires a manualdata-wp-on--clickto open the lightbox.::backdroppseudo element is removed immediately upon hiding the lightbox, so animation to fade out is not possible.handleKeydownaction on the lightbox does not fire. Still researching why...