Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Surface menu name in the List View next to the Navigation block #68446

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

yogeshbhutkar
Copy link
Contributor

@yogeshbhutkar yogeshbhutkar commented Jan 1, 2025

Fixes Point 2 of #68177

What, Why and How?

This PR enhances the Navigation block by displaying the menu name alongside the Navigation text. It achieves this by introducing a new menuTitle attribute, initialized during block rendering. The label is displayed using the __experimentalLabel attribute, passed to the initBlock method for rendering.

Testing Instructions

  1. Create a Navigation Block.
  2. Try renaming it.
  3. Notice the name change reflected in the List View (left side) next to the Navigation text.

Screencast

Convert to GIF Jan 1 2025

Screenshots

Before After
Screenshot 2025-01-01 at 3 01 18 PM Screenshot 2025-01-01 at 3 00 30 PM

@yogeshbhutkar yogeshbhutkar changed the title Navigation: Surface menu name in the List View next to the Navigation block. Navigation: Surface menu name in the List View next to the Navigation block Jan 1, 2025
@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review January 1, 2025 10:03
Copy link

github-actions bot commented Jan 1, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants