Editor: Remove constants for notices #68361
Merged
+6
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @aduth. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Dec 27, 2024
| @@ -347,7 +346,6 @@ export const trashPost = | |||
| const postType = await registry | |||
| .resolveSelect( coreStore ) | |||
| .getPostType( postTypeSlug ); | |||
| registry.dispatch( noticesStore ).removeNotice( TRASH_POST_NOTICE_ID ); | |||
There was a problem hiding this comment.
There is no need to remove the failed trash notice. If actions fail again, the same notice will be reused because the notice has the same static ID. Users will be redirected if they succeed, and WP will display a different notice.
|
Size Change: -20 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 425e33b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12550667396
|
tyxla
reviewed
Dec 30, 2024
| @@ -113,7 +108,7 @@ export function getNotificationArgumentsForSaveFail( data ) { | |||
| return [ | |||
| noticeMessage, | |||
| { | |||
| id: SAVE_POST_NOTICE_ID, | |||
There was a problem hiding this comment.
I think there was a reason that the save success and save error notices were using the same notice, though.
Right now if you do the following:
- Save a post successfully
- Quickly block the save REST API request URL
- Save quickly, see failure notice
You'll see the success notice remains together with the failure one:
Haven't tested, but I believe that if you keep the same ID for both error and success, the new (failure) notice should remove the old (success) one properly.
There was a problem hiding this comment.
That's a good point. I'll update to use the same string value again.
| @@ -347,7 +346,6 @@ export const trashPost = | |||
| const postType = await registry | |||
| .resolveSelect( coreStore ) | |||
| .getPostType( postTypeSlug ); | |||
| registry.dispatch( noticesStore ).removeNotice( TRASH_POST_NOTICE_ID ); | |||
Comment on lines
-14
to
-15
| export const SAVE_POST_NOTICE_ID = 'SAVE_POST_NOTICE_ID'; | ||
| export const TRASH_POST_NOTICE_ID = 'TRASH_POST_NOTICE_ID'; |
There was a problem hiding this comment.
Thanks for working to clean those up 👏
|
Thanks for the review, @tyxla! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #11202.
PR updates IDs for editor notices to use string values directly instead of unnecessary constants.
Testing Instructions
Testing Instructions for Keyboard
Same.