Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Submenu: Fix color handling and inheritance #68351

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from

Conversation

yogeshbhutkar
Copy link
Contributor

@yogeshbhutkar yogeshbhutkar commented Dec 27, 2024

What, Why & How?

Testing Instructions for Keyboard

  1. Navigate to a Post/Page edit screen.
  2. Create a Navigation Block.
  3. Try setting up different permutations for text and background properties along with custom colors.
  4. Notice the bugs mentioned in the issue are now fixed.

Screencasts

The following are the expected outcomes that the submenu block should abide by.

If the navigation block has either a background or a text color assigned, and there's no color provided for the submenu & overlay text or submenu & overlay background, then navigation blocks color should be inherited. ( ✅ )

one

If the navigation block has specified a color, but, the submenu parent has also specified a color (background and text ), the submenu container should still inherit the color from the navigation block. ( ✅ )

two

If submenu & overlay text or submenu & overlay background values are provided, these should overwrite the values of navigation block. ( ✅ )

three

if only submenu's color and background value are passed, then it shouldn't override the value of the submenu container. Container's values must be either inherited from navigation or from the dedicated submenu control options on navigation. ( ✅ )

four

Closes: #68350

@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review January 1, 2025 08:12
Copy link

github-actions bot commented Jan 1, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Jan 1, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation Sub Menu: Bugs in color handling and block context
1 participant