Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Fixing Text Contrast for Dark Mode #68349

Merged
merged 5 commits into from
Dec 30, 2024

Conversation

im3dabasia
Copy link
Contributor

@im3dabasia im3dabasia commented Dec 27, 2024

Part of: #66454
Comment: #66454 (comment)

Work in progress

What?

Fixes the components labels/headings in the dark mode

Testing Instructions

  1. Run npm run storybook:dev.
  2. Open Storybook at http://localhost:50240/.
  3. Verify that the following components work well in dark mode, and ensure that all other modes continue to function as they did previously.

Screenshots or screencast

AnglePickerControl

Before After
image image

CustomGradientPicker

Before After
image image

FocalPointPicker

Before After
image image

GradientPicker

Before After
image image

InputControl

Before After
image image

NumberControl

Before After
image image

PaletteEdit

Before After
image image

QueryControl

Before After
image image

SelectControl

Before After
image image

TreeSelect

Before After
image image

UnitControl

Before After
image image

@im3dabasia im3dabasia marked this pull request as ready for review December 28, 2024 09:31
Copy link

github-actions bot commented Dec 28, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@im3dabasia
Copy link
Contributor Author

Hi @t-hamano, when you have a moment, please review my PR addressing labels and headings visibility in dark mode, extracted from this comment.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Dec 28, 2024
@t-hamano t-hamano requested a review from a team December 28, 2024 09:59
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great! 👍 ✅

I've fixed a few snapshot and unit tests that needed to be updated, and will ship it shortly. 🚢

Thanks for your contribution @im3dabasia 🙌

@tyxla tyxla merged commit 4b847f9 into WordPress:trunk Dec 30, 2024
61 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants