Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom Out Inserter: enable Dynamic Labels #68310

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

yogeshbhutkar
Copy link
Contributor

@yogeshbhutkar yogeshbhutkar commented Dec 26, 2024

Fixes: #68309

What, Why and How?

This PR enhances the Zoom Out Inserter by introducing dynamic labels and tooltips, leveraging a global state to track the selectedTab.

It resolves a bug where the static text Drop Pattern and the Add Pattern tooltip were displayed universally, regardless of the content type being interacted with. These values are now dynamically updated based on the selected tab, ensuring accurate and context-sensitive feedback.

Testing Instructions

  1. Navigate to edit a post or create a new post.
  2. Toggle Show Template on.
  3. Activate the Zoom Out Toggle.
  4. Hover over the + button, and notice the tooltip. Notice, it updates based on the sidebar's Tab.
  5. Verify the label being shown is now dynamic and updates based on the Tab selected.

Screencast

Screen.Recording.2024-12-26.at.1.18.12.PM.mov

@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review December 26, 2024 10:13
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] Zoom Out labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] Zoom Out [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zoom Out Inserter: Drop Pattern label mismatch with Block and Media elements.
2 participants