Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text description of the "Contain text cursor inside block" preference #68132

Open
wants to merge 16 commits into
base: trunk
Choose a base branch
from

Conversation

karthick-murugan
Copy link
Contributor

What?

Fixes #57351

This PR updates the description of the "Contain text cursor inside block" preference in the Accessibility options.

Why?

The previous description implied the feature was primarily beneficial for screen reader users, which was misleading. The feature impacts all keyboard users, providing better control while navigating between blocks. The new description is clearer, more user-focused, and emphasizes its broader applicability.

How?

The description was rewritten to explain the functionality in simpler terms that resonate with casual users, outlining how it affects keyboard navigation and enhances usability.

Testing Instructions

  1. Open the WordPress admin dashboard.
  2. Navigate to Options > Preferences > Accessibility.
  3. Locate the "Contain text cursor inside block" option.
  4. Verify the updated description is displayed correctly.
  5. Confirm the description accurately explains the behaviour by testing the preference in a post or page.

Testing Instructions for Keyboard

Screenshots or screencast

Before

before_preference

After

after_preference

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: karthick-murugan <[email protected]>
Co-authored-by: joedolson <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@karthick-murugan
Copy link
Contributor Author

@joedolson - Please have a look at this PR when you get some time.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Editor /packages/editor labels Jan 13, 2025
@Mamaduka Mamaduka requested a review from joedolson January 13, 2025 16:02
@joedolson
Copy link
Contributor

It's definitely an improvement. I think swapping the word 'Restricts' for 'Keeps' is not an improvement; 'Keeps' is simpler.

I still think that "while navigating" isn't enough information. Can we specify what type of navigation, e.g.:

"Keeps the text cursor within blocks while navigating with arrow keys, preventing it from moving to other blocks, enhancing accessibility for keyboard users."

We could omit the phrase 'enhancing accessibility for keyboard users'. I don't think keeping that phrase is specifically necessary, though I don't think it hurts, either - it helps give context for all users about what the value of this option is. But this is an option within the accessibility settings section, so I don't see it as necessary to explain that it's an accessibility enhancement.

Copy link
Contributor

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes in #68132 (comment)

@karthick-murugan
Copy link
Contributor Author

Suggested changes in #68132 (comment)

@joedolson - Updated the description as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update text description of the "Contain text cursor inside block" preference
3 participants