Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read More: Refactor settings panel to use ToolsPanel #67925

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Read More: Refactor settings panel to use ToolsPanel #67925

merged 2 commits into from
Jan 17, 2025

Conversation

SainathPoojary
Copy link
Contributor

@SainathPoojary SainathPoojary commented Dec 13, 2024 •
edited
Loading

Issue: #67944
Part of #67813

What?

Update the Read More block to use the ToolsPanel and ToolsPanelItem components for settings management.

Screenshots or screencast

Before After
image image

@SainathPoojary SainathPoojary mentioned this pull request Dec 13, 2024
Open
@SainathPoojary SainathPoojary marked this pull request as ready for review December 13, 2024 09:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SainathPoojary <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@fabiankaegy fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] Read More Affects the Read More Block labels Dec 13, 2024
@fabiankaegy fabiankaegy linked an issue Dec 13, 2024 that may be closed by this pull request
Refactor "Settings" panel of Read More block to use ToolsPanel instead of PanelBody #67944
Closed
t-hamano
t-hamano reviewed Jan 12, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Almost everything is working correctly, but it would be a good idea to add the dropdownMenuProps to ensure that the drop-down menu is positioned on the left (Example).

@SainathPoojary SainathPoojary force-pushed the refactor-read-more-block-setting branch from 444e437 to c88d91b Compare January 15, 2025 08:14
@t-hamano
Copy link
Contributor

@SainathPoojary Could you rebase this PR? It should resolve the E2E test failure.

@SainathPoojary SainathPoojary force-pushed the refactor-read-more-block-setting branch from 14e29cc to e82af11 Compare January 17, 2025 09:06
@SainathPoojary
Copy link
Contributor Author

Hey @t-hamano, I’ve rebased the PR, and all checks are now passing. Please take a look whenever you have a moment.

fabiankaegy
fabiankaegy approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected for me and the code look good :) Thank you!

@fabiankaegy fabiankaegy merged commit ebab640 into WordPress:trunk Jan 17, 2025
63 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.2 milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano left review comments

@fabiankaegy fabiankaegy fabiankaegy approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Block] Read More Affects the Read More Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 20.2
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Read More block to use ToolsPanel instead of PanelBody
3 participants
@SainathPoojary @t-hamano @fabiankaegy