Search Block: Refactoring settings panel

[benazeer-ben]

What?

Part of: #67813

Why?

As per ticket definition we need to refactor Search Block code to include ToolsPanel instead of PanelBody.

How?

Refactored Search Block code to include ToolsPanel instead of PanelBody.

Testing Instructions

• Go to WP admin dashboard
• Edit any post/ page
• Add search block.
• Check settings panel of the search block and verify the change.

Screenshots or screencast

Before	After

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: benazeer-ben <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[fabiankaegy]

Thank you for working on this :)

In order to keep the scope of this conversation as small as possible we should retain the current status quo as much as possible. So by default any controls that were visible by default should continue to be shown by default.

CleanShot.2024-12-13.at.09.12.55.mp4

[t-hamano]

Thanks for the PR!

To me, the following dropdown looks strange:

Because the two controls work in sync.

I think what is expected here is to place the two controls inside a single ToolsPanelItem.

[t-hamano]

LGTM! I have one final suggestion that I'd be happy if you could check out.

747801532fb0930a36d91c476062a13a.mp4

Since the proposed changes have already been resolved: #67907 (comment)