Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature to set alpha value to Highlight #67525

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

shimotmk
Copy link
Contributor

@shimotmk shimotmk commented Dec 3, 2024

What?

fix #67453

Add a feature to set alpha value to Highlight

Why?

Being able to set alpha color expands the range of design possibilities!

How?

Testing Instructions

  1. Open a post or page.
  2. Insert a paragraph block.
  3. Set Highlight text or background alpha color

Testing Instructions for Keyboard

Screenshots or screencast

textcoloralpha.mp4
Before After
before after

@shimotmk shimotmk requested a review from ellatrix as a code owner December 3, 2024 12:20
Copy link

github-actions bot commented Dec 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shimotmk
Copy link
Contributor Author

Could someone please take a look at this pull request? 🙂

@cbravobernal cbravobernal added [Package] Format library /packages/format-library [Type] Enhancement A suggestion for improvement. labels Dec 16, 2024
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply.

This feature works well and I think it's ready to ship. I think it's very useful when you want to apply a soft background color that blends in a bit with the text:

image

I re-read #34680 where the background color feature was implemented, but there was no specific mention of any concerns about adding alpha color.

One thing to note is that alpha color will be available for both text color and background color.

I believe this is a very important change and would like to solicit additional feedback. cc @WordPress/gutenberg-core

@ramonjd ramonjd added the Needs Design Feedback Needs general design feedback. label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Package] Format library /packages/format-library [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a feature to set alpha value to Highlight
4 participants