Skip to content

Conversation

@amitraj2203
Copy link
Contributor

@amitraj2203 amitraj2203 commented Nov 5, 2024

What?

Closes #66723

Why?

Adds anchor support in details block

Testing Instructions

  1. Create a post or page.
  2. Insert a details block.
  3. On the Inspector control, open the Advanced Panel and see the HTML Anchor option

@github-actions
Copy link

github-actions bot commented Nov 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: amitraj2203 <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: skorasaurus <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@amitraj2203 amitraj2203 requested a review from t-hamano November 5, 2024 05:46
@amitraj2203 amitraj2203 added [Type] Enhancement A suggestion for improvement. [Block] Details Affects the Details Block - used to display content which can be shown/hidden labels Nov 5, 2024
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think all static blocks need anchor support, as was done in #23197.

@t-hamano
Copy link
Contributor

t-hamano commented Nov 6, 2024

@amitraj2203 Could you rebase this PR? The stalling CI should work (See #66771).

@amitraj2203
Copy link
Contributor Author

@t-hamano Done

@t-hamano t-hamano merged commit bee12b1 into trunk Nov 8, 2024
@t-hamano t-hamano deleted the adds/anchor-support-details-block branch November 8, 2024 08:36
@github-actions github-actions bot added this to the Gutenberg 19.7 milestone Nov 8, 2024
@skorasaurus
Copy link
Member

Thank you for your work on this =)

karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
Co-authored-by: amitraj2203 <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: skorasaurus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Details Affects the Details Block - used to display content which can be shown/hidden [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Details Block: Add Anchor Support

4 participants