Skip to content

Writing Flow: avoid range removal in multi selection and select all #64658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stokesman wants to merge 1 commit into from
Closed

Writing Flow: avoid range removal in multi selection and select all #64658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/block-editor/src/components/writing-flow/use-multi-selection.js
View file
Open in desktop
Copy link
Contributor Author

@stokesman stokesman Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L82, removeAllRanges was added here in #42340. I tried testing to make sure this doesn’t regress that issue but I'm not certain I correctly understood the testing instructions.

Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,10 @@ export default function useMultiSelection() {
node.contentEditable = true;

// For some browsers, like Safari, it is important that focus
// happens BEFORE selection removal.
// happens BEFORE updating the selection.
node.focus();

defaultView.getSelection().removeAllRanges();
defaultView.getSelection().setPosition( node );
},
[
hasMultiSelection,
Expand Down
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/writing-flow/use-select-all.js
View file
Open in desktop
Copy link
Contributor Author

@stokesman stokesman Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removalAllRanges was added in #42711 and I didn’t see mention of what necessitated it. I suppose all of the List block features could use testing? I haven’t found any issues so far.

Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export default function useSelectAll() {
if ( rootClientId ) {
node.ownerDocument.defaultView
.getSelection()
.removeAllRanges();
.setPosition( node );
selectBlock( rootClientId );
}
return;
Expand Down