Post: add a max length to the post password protected field #64156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Bug
|
Size Change: +9 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
peterwilsoncc
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
This looks good to me.
I'm wondering if we ought to add an inline alert if the user attempts to enter a password that is too long but don't think it's a blocker.
Note for others testing: when viewing the post on the front-end to test, you will need to remove the size attribute from the form field for it to accept passwords longer than 20 characters. This is been fixed in core-61703
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Yeah, that might help to inform users in lieu of a cryptic server error. I was also thinking that it could be a little UX improvement to uncheck the password checkbox if a user clears it. At the moment it stays open with an empty field. 0411e662db3a7a7609847dd018095475.mp4I didn't want to overcomplicate this change though. I can create an issue for the above so it's on record. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #64155
Limits the post password protected field to 255 chars.
Why?
To avoid the database error:
See explanation in #64155
How?
maxlengthHTML attribute.Testing Instructions
The following password has 258 characters.
glom-our-stir-bespeak-normalcy-wavelet-spitz-alsatian-miami-gizmo-sibling-riflemen-fugal-caiman-guy-tern-flick-nearer-dow-patch-grudge-prawn-debuting-scorch-brunei-waif-hibachi-beijing-tweet-share-homeward-ratline-postal-dissent-tigris-baldpate-clumsy-centrePaste it into the password field and confirm that it's truncated to 255:
glom-our-stir-bespeak-normalcy-wavelet-spitz-alsatian-miami-gizmo-sibling-riflemen-fugal-caiman-guy-tern-flick-nearer-dow-patch-grudge-prawn-debuting-scorch-brunei-waif-hibachi-beijing-tweet-share-homeward-ratline-postal-dissent-tigris-baldpate-clumsy-cenSave and check that the password work on the frontend to unlock the post.