Skip to content

strip whitespaces in render_block_core_cover #40859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamziel merged 10 commits into from
Jun 27, 2022
Merged

strip whitespaces in render_block_core_cover #40859

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
09739d8
strip whitespaces in render_block_core_cover
navigatrum May 5, 2022
849197a
amend regex
navigatrum May 18, 2022
9be451c
Cover-block: edit regex to insert the featured img
navigatrum May 26, 2022
ee8fe32
edit cover block regex for featured image #4
navigatrum Jun 15, 2022
2981dd7
Add quotes around the regexp
adamziel Jun 23, 2022
e374216
close bracket ad reformat comment
navigatrum Jun 24, 2022
7d65028
retry to fix
navigatrum Jun 25, 2022
98424c7
Update packages/block-library/src/cover/index.php
adamziel Jun 27, 2022
7cd71a2
Update packages/block-library/src/cover/index.php
adamziel Jun 27, 2022
4a4aa98
Merge branch 'trunk' into edit-cover-block-featured-image
adamziel Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions packages/block-library/src/cover/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,15 @@ function render_block_core_cover( $attributes, $content ) {

$image = get_the_post_thumbnail( null, 'post-thumbnail', $attr );

$content = str_replace(
'</span><div',
'</span>' . $image . '<div',
$content
);

/*
* Inserts the featured image between the (1st) cover 'background' `span` and 'inner_container' `div`,
* and removes eventual withespace characters between the two (typically introduced at template level)
*/
$inner_container_start = '/<div\b[^>]+wp-block-cover__inner-container[\s|"][^>]*>/U';
if ( 1 === preg_match( $inner_container_start, $content, $matches, PREG_OFFSET_CAPTURE ) ) {
$offset = $matches[0][1];
$content = substr( $content, 0, $offset ) . $image . substr( $content, $offset );
}
} else {
if ( in_the_loop() ) {
update_post_thumbnail_cache();
Expand Down