FSE: Prevent warnings if selector_data fields not defined in theme.json #26974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.19 MB ℹ️ View Unchanged
|
gziolo
added
Global Styles
Member
|
https://github.com/WordPress/gutenberg/runs/1398039767#step:7:106 PHP linters is unhappy about something. Aside, it looks like we have several linting warnings reported. It'd be great to investigate separately. |
Member
|
Thanks for reporting, Marcus. I'm addressing this at #26991 as we need a different approach (bail if no proper metadata). I can't repro the issue, but that PR is needed anyway to prevent cases where the blocks don't define the proper metadata. Could you confirm if that fixes what you see? |
Member
Author
|
@nosolosw Looks like that does it, thanks! I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While testing something unrelated on latest master I noticed warnings started appearing.
This change prevents the warnings from showing if theme.json data is not defined.
How has this been tested?
Using non-FSE site without a theme.json and saw the warnings prior
Applying this fix prevents warnings from showing.