Skip to content

Add back providesContext block attribute #23212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
noahtallen wants to merge 3 commits into from
Closed

Add back providesContext block attribute #23212

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1e27ae
Use better name for context in block registration
noahtallen Jun 16, 2020
091b02c
Rename requiresContex to usesContext
noahtallen Jun 16, 2020
1912fe4
Revert to context
noahtallen Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions lib/compat.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,17 +167,18 @@ function register_block_type_from_metadata( $file_or_folder, $args = array() ) {

$settings = array();
$property_mappings = array(
'title' => 'title',
'category' => 'category',
'context' => 'context',
'parent' => 'parent',
'icon' => 'icon',
'description' => 'description',
'keywords' => 'keywords',
'attributes' => 'attributes',
'supports' => 'supports',
'styles' => 'styles',
'example' => 'example',
'title' => 'title',
'category' => 'category',
'context' => 'context',
'providesContext' => 'providesContext',
Copy link
Member

@spacedmonkey spacedmonkey Jun 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'providesContext' => 'providesContext',
'providesContext' => 'provides_context',

'parent' => 'parent',
'icon' => 'icon',
'description' => 'description',
'keywords' => 'keywords',
'attributes' => 'attributes',
'supports' => 'supports',
'styles' => 'styles',
'example' => 'example',
);

foreach ( $property_mappings as $key => $mapped_key ) {
Expand Down