Skip to content

Types: Hide element, primitives, icons declarations #21613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sirreal merged 3 commits into from
Apr 15, 2020
Merged

Types: Hide element, primitives, icons declarations #21613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6df73e9
"Unpublish" @wordpress/element build-types
sirreal Apr 15, 2020
2384385
Add CHANGELOG
sirreal Apr 15, 2020
1f013eb
Remove primitives, icons types
sirreal Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/element/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
## Master

### Bug Fix

- Hide TypeScript type declarations ([#21613](https://github.com/WordPress/gutenberg/pull/21613))
after they were found to conflict with DefinitelyTyped provided declarations.

## 2.13.0 (2020-04-15)

### New Features

- Include TypeScript type declarations ([#21248](https://github.com/WordPress/gutenberg/pull/21248))
- Graduated `__experimentalCreateInterpolateElement` function to stable api: `createInterpolateElement` (see [20699](https://github.com/WordPress/gutenberg/pull/20699))

Expand Down
1 change: 0 additions & 1 deletion packages/element/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
"main": "build/index.js",
"module": "build-module/index.js",
"react-native": "src/index",
"types": "build-types",
"sideEffects": false,
"dependencies": {
"@babel/runtime": "^7.9.2",
Expand Down
9 changes: 8 additions & 1 deletion packages/icons/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
## Master

Include TypeScript type declarations ([#21487](https://github.com/WordPress/gutenberg/pull/21487))
### Bug Fix

- Hide TypeScript type declarations ([#21613](https://github.com/WordPress/gutenberg/pull/21613))
after they were found to conflict with DefinitelyTyped provided declarations.

## 1.3.0 (2020-04-15)

- Include TypeScript type declarations ([#21487](https://github.com/WordPress/gutenberg/pull/21487))

## 1.0.0 (2020-02-04)

Expand Down
1 change: 0 additions & 1 deletion packages/icons/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"main": "build/index.js",
"module": "build-module/index.js",
"react-native": "src/index",
"types": "build-types",
"dependencies": {
"@babel/runtime": "^7.9.2",
"@wordpress/element": "../element",
Expand Down
9 changes: 8 additions & 1 deletion packages/primitives/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
## Master

Include TypeScript type declarations ([#21482](https://github.com/WordPress/gutenberg/pull/21482))
### Bug Fix

- Hide TypeScript type declarations ([#21613](https://github.com/WordPress/gutenberg/pull/21613))
after they were found to conflict with DefinitelyTyped provided declarations.

## 1.3.0 (2020-04-15)

- Include TypeScript type declarations ([#21482](https://github.com/WordPress/gutenberg/pull/21482))

## 1.0.0

Expand Down
1 change: 0 additions & 1 deletion packages/primitives/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"module": "build-module/index.js",
"react-native": "src/index",
"sideEffects": false,
"types": "build-types",
"dependencies": {
"@babel/runtime": "^7.9.2",
"@wordpress/element": "file:../element",
Expand Down
9 changes: 6 additions & 3 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,23 @@
{ "path": "packages/autop" },
{ "path": "packages/blob" },
{ "path": "packages/block-editor" },
{ "path": "packages/element" },
{ "path": "packages/dom-ready" },
{ "path": "packages/escape-html" },
{ "path": "packages/html-entities" },
{ "path": "packages/i18n" },
{ "path": "packages/icons" },
{ "path": "packages/is-shallow-equal" },
{ "path": "packages/prettier-config" },
{ "path": "packages/primitives" },
{ "path": "packages/priority-queue" },
{ "path": "packages/project-management-automation" },
{ "path": "packages/token-list" },
{ "path": "packages/url" },
{ "path": "packages/warning" }

// Temporarily disabled due to conflicts with 3rd party DefinitelyTyped types
// See https://github.com/WordPress/gutenberg/pull/21613
// { "path": "packages/element" },
// { "path": "packages/icons" },
// { "path": "packages/primitives" }
],
"files": []
}