-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Build: Add TypeScript version validation #21208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +445 B (0%) Total Size: 856 kB
ℹ️ View Unchanged
|
aduth
approved these changes
Mar 27, 2020
Member
aduth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda makes me wonder if this sort of thing could be generalized for all dependencies. It's quite similar in purpose to the wp-scripts check-engines script as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide clear errors due to mismated TypeScript versions. This should help make the transition period from #18942 smoother.
Add
validate-typescript-versionbin that will be used bylint-stagedtypechecker and inbuild:package-typesscript.This helps to prevent cryptic errors when an older TypeScript module is present in
node_modulesand requires updating.Without this change, lint-staged and
npm run build:package-typeswould print this error:This is due to an incompatible TypeScript package. With this change, these script will print this error:
How has this been tested?
Screenshots
Types of changes
Developer experience improvement. No changelog entry necessary.
Checklist: