Skip to content

Is Shallow Equal: Add types #19090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sirreal merged 1 commit into from
Dec 12, 2019
Merged

Is Shallow Equal: Add types #19090

sirreal merged 1 commit into from
Dec 12, 2019

Conversation

@sirreal
Copy link
Member

@sirreal sirreal commented Dec 12, 2019 •
edited
Loading

Description

Part of #18838
Extracted from #18942

Add types to is-shallow-equal package.

Testing Instructions:

Verify type checking passes:

npm run lint-types

@sirreal sirreal added [Package] is-shallow-equal /packages/is-shallow-equal [Type] Code Quality Issues or PRs that relate to code quality labels Dec 12, 2019
@sirreal sirreal marked this pull request as ready for review December 12, 2019 08:55
@sirreal sirreal requested a review from aduth as a code owner December 12, 2019 08:55
@aduth aduth mentioned this pull request Dec 12, 2019
Closed
75 tasks
aduth
aduth approved these changes Dec 12, 2019
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase?

@sirreal sirreal force-pushed the add/types-is-shallow-equal branch from 4fc92b0 to 791599b Compare December 12, 2019 15:39
@sirreal
Copy link
Member Author

sirreal commented Dec 12, 2019

Rebased.

@sirreal sirreal merged commit cbbf1fe into master Dec 12, 2019
@sirreal sirreal deleted the add/types-is-shallow-equal branch December 12, 2019 15:57
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduth aduth aduth approved these changes

Assignees

No one assigned

Labels

[Package] is-shallow-equal /packages/is-shallow-equal [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Milestone

Gutenberg 7.2

Development

Successfully merging this pull request may close these issues.

4 participants

@sirreal @aduth @youknowriad