Block Library: Implement pass-through behavior for Column block #16024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Status] Blocked
aduth
requested review from
Soean,
ajitbohra,
ellatrix,
gziolo,
jorgefilipecosta,
notnownikki,
talldan and
youknowriad
as code owners
gziolo
approved these changes
Jun 10, 2019
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
There is one line which needs to be double checked. Otherwise, code looks good and tests well.
gziolo
requested changes
Jun 10, 2019
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
I noticed that there are 2 failing e2e tests. They both seem to be related to the changes introduced.
Co-Authored-By: Grzegorz (Greg) Ziółkowski <[email protected]>
Member
Author
Yeah, while I've not yet looked at the specific failings, in reflection I recall there being some test cases written as assuming the column as a "stop" point for, e.g. ArrowDown. These would need to be updated since that's no longer true. |
Member
Author
|
We may revisit this in the future, but for now this is not mergeable in its current state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #15927
Closes #7694
Partially addresses #15660
This pull request seeks to implement a "pass-through" behavior for blocks.
It is implemented as two parts:
With these changes, it should become impossible to select a Column block either by clicking on it, or by using arrow keys to navigate blocks. It is technically still possible to select a Column block via the Block Navigation menu. I don't personally have an issue with this, since the block is technically still present, and the primary motivation is in solving the usability problems around standard selection interactions (which this achieves).
Blocked: While this pull request is considered complete so far as implementing the pass-through behavior, it would need to be merged only in combination with a separate pull request which would recreate the existing Column attributes customizations of widths and vertical alignment assignment. My plan is to create separate pull requests for these distinct efforts, and merge them all at once only when they have each been approved.
Testing Instructions:
Verify that click and arrow key navigation to a Column block is not possible, but that otherwise behaviors are unaffected: