Navigation Submenu: Fix color handling and inheritance #68351
Conversation
…failing test case
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
What, Why & How?
Testing Instructions for Keyboard
Screencasts
The following are the expected outcomes that the submenu block should abide by.
If the
navigation blockhas either abackgroundor atextcolor assigned, and there's no color provided for thesubmenu & overlay textorsubmenu & overlay background, thennavigationblocks color should be inherited. ( ✅ )If the
navigation blockhas specified a color, but, thesubmenu parenthas also specified a color (background and text ), the submenu container should still inherit the color from thenavigation block. ( ✅ )If
submenu & overlay textorsubmenu & overlay backgroundvalues are provided, these should overwrite the values ofnavigation block. ( ✅ )if only
submenu'scolor and background value are passed, then it shouldn't override the value of thesubmenu container.Container'svalues must be either inherited fromnavigationor from the dedicatedsubmenucontrol options onnavigation. ( ✅ )Closes: #68350