Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Sub Menu: Bugs in color handling and block context #68350

Open
3 of 6 tasks
yogeshbhutkar opened this issue Dec 27, 2024 · 0 comments · May be fixed by #68351
Open
3 of 6 tasks

Navigation Sub Menu: Bugs in color handling and block context #68350

yogeshbhutkar opened this issue Dec 27, 2024 · 0 comments · May be fixed by #68351
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@yogeshbhutkar
Copy link
Contributor

yogeshbhutkar commented Dec 27, 2024

Description

Here are the issues identified while interacting with the Navigation Submenu component:

  1. Color Panel Behavior:
    The color panel for the Navigation Submenu component allows setting text and background colors. However, these colors only work with predefined values sourced from template/theme.json. Custom values are not applied successfully.

Image

Image

  1. Color Application Discrepancy:
    When text and background colors are set for the submenu component, they correctly apply to the submenu itself, leaving the overlay text and background settings unaffected in the editor (as intended). However, on the front end, these colors are mistakenly applied to the submenu container instead of the submenu parent, overriding the overlay settings and causing inconsistency between the Editor and the Front End.

Image

I'm unsure if these issues are a regression resulting from recent changes to the component.

Step-by-step reproduction instructions

  1. Navigate to a Post/Page edit screen.
  2. Create a Navigation Block.
  3. Try setting up different permutations for text and background properties along with custom colors.
  4. Notice the discrepancies stated above.

Screenshots, screen recording, code snippet

Corresponding screenshots and recordings are provided in the issue description.

Environment info

  • Gutenberg Plugin: Trunk (5af740f)
  • WordPress Version: 6.8-alpha-59361
  • OS: macOS Sequoia

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@yogeshbhutkar yogeshbhutkar added the [Type] Bug An existing feature does not function as intended label Dec 27, 2024
@yogeshbhutkar yogeshbhutkar changed the title Navigation Sub Menu: Minor bugs in color handling and block context Navigation Sub Menu: Bugs in color handling and block context Dec 27, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant