fix: Added typeof check in fontSizeValue

WordPress · Jan 17, 2025 · e5dfb84 · e5dfb84
1 parent 041ca27
commit e5dfb84
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/packages/block-editor/src/hooks/typography.js b/packages/block-editor/src/hooks/typography.js
@@ -53,9 +53,11 @@ function styleToAttributes( style ) {
 	const updatedStyle = { ...omit( style, [ 'fontFamily' ] ) };
 	const fontSizeValue = style?.typography?.fontSize;
 	const fontFamilyValue = style?.typography?.fontFamily;
-	const fontSizeSlug = fontSizeValue?.startsWith( 'var:preset|font-size|' )
-		? fontSizeValue.substring( 'var:preset|font-size|'.length )
-		: undefined;
+	const fontSizeSlug =
+		typeof fontSizeValue === 'string' &&
+		fontSizeValue?.startsWith( 'var:preset|font-size|' )
+			? fontSizeValue.substring( 'var:preset|font-size|'.length )
+			: undefined;
 	const fontFamilySlug = fontFamilyValue?.startsWith(
 		'var:preset|font-family|'
 	)

diff --git a/test/emptytheme/theme.json b/test/emptytheme/theme.json
@@ -2,18 +2,15 @@
 	"$schema": "../../schemas/json/theme.json",
 	"version": 3,
 	"settings": {
-		"appearanceTools": true,
 		"layout": {
 			"contentSize": "840px",
 			"wideSize": "1100px"
+		},
+		"color": {
+			"defaultPalette": false
+		},
+		"typography": {
+			"defaultFontSizes": false
 		}
-	},
-	"customTemplates": [
-		{
-			"name": "custom-template",
-			"title": "Custom",
-			"postTypes": [ "post" ]
-		}
-	],
-	"patterns": [ "short-text-surrounded-by-round-images", "partner-logos" ]
+	}
 }