Add CondicionIVAReceptorId field #230
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhyNotHugo
force-pushed
the
client-vat-condition
branch
from
6f325ad to
2d6b590
Compare
WhyNotHugo
reviewed
Feb 27, 2025
Comment on lines
+1
to
+42
| from __future__ import annotations | ||
|
|
||
| from django.core.management.base import BaseCommand | ||
| from django.utils.translation import gettext as _ | ||
|
|
||
| from django_afip import clients, models, serializers | ||
|
|
||
|
|
||
| class Command(BaseCommand): | ||
| help = _( | ||
| "Retrieves all the ClientVatConditions from the AFIP server and updates it in the DB." | ||
| ) | ||
| requires_migrations_checks = True | ||
|
|
||
| def add_arguments(self, parser): | ||
| parser.add_argument( | ||
| "cuit", | ||
| type=int, | ||
| help=_("CUIT of the tax payer to be used to authenticate."), | ||
| ) | ||
|
|
||
| def handle(self, *args, **options) -> None: | ||
| from django_afip.models import TaxPayer | ||
|
|
||
| tax_payer = TaxPayer.objects.get(cuit=options["cuit"]) | ||
| ticket = tax_payer.get_or_create_ticket("wsfe") | ||
|
|
||
| client = clients.get_client("wsfe", sandbox=tax_payer.is_sandboxed) | ||
| response = client.service.FEParamGetCondicionIvaReceptor( | ||
| serializers.serialize_ticket(ticket), | ||
| ) | ||
|
|
||
| for condition in response.ResultGet.CondicionIvaReceptor: | ||
| models.ClientVatCondition.objects.get_or_create( | ||
| code=condition.Id, | ||
| defaults={ | ||
| "description": condition.Desc, | ||
| "cmp_clase": condition.Cmp_Clase, | ||
| }, | ||
| ) | ||
| self.stdout.write(self.style.SUCCESS(f"Loaded {condition.Desc}")) | ||
| self.stdout.write(self.style.SUCCESS("All done!")) |
There was a problem hiding this comment.
Esto debería ir en scripts/dump_metadata.py.
| @@ -94,6 +94,7 @@ def serialize_receipt(receipt: Receipt): # noqa: ANN201 | |||
| ImpTrib=sum(tax.amount for tax in taxes), | |||
| MonId=receipt.currency.code, | |||
| MonCotiz=receipt.currency_quote, | |||
| CondicionIVAReceptorId=receipt.client_vat_condition.code, | |||
There was a problem hiding this comment.
Crashes if receipt.client_vat_condition is None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Receipt.client_vat_conditionFK to ClientVatCondition.CondicionIVAReceptorId=receipt.client_vat_condition.codetoserialize_receipt.load_client_vat_conditionscommand to retrieve ClientVatConditions from FEParamGetCondicionIvaReceptor and sync them.Potential improvements
I think that there are some improvements that could be made to this implementation:
cmp_clasefield of ClientVatCondition to ReceiptTypes.This implementation has an Issue
When serializing a Receipt in the
serialize_receiptfunction theFECAEDetRequestmethod will return this error:This is because the
Clientcreated asf = _LazyFactory()and used by the serializer is being created with the default parametersandbox=False. This causes the error because the parameterCondicionIVAReceptorIdis currently only available on Sandbox mode only.Related to: