Skip to content

Conversation

@jlucaso1
Copy link
Collaborator

@whiskeysockets-bot
Copy link
Contributor

whiskeysockets-bot commented Oct 21, 2025

Thanks for opening this pull request and contributing to the project!

The next step is for the maintainers to review your changes. If everything looks good, it will be approved and merged into the main branch.

In the meantime, anyone in the community is encouraged to test this pull request and provide feedback.

✅ How to confirm it works

If you’ve tested this PR, please comment below with:

Tested and working ✅

This helps us speed up the review and merge process.

📦 To test this PR locally:

# NPM
npm install @whiskeysockets/baileys@WhiskeySockets/Baileys#feat-custom-logger-libsignal

# Yarn (v2+)
yarn add @whiskeysockets/baileys@WhiskeySockets/Baileys#feat-custom-logger-libsignal

# PNPM
pnpm add @whiskeysockets/baileys@WhiskeySockets/Baileys#feat-custom-logger-libsignal

If you encounter any issues or have feedback, feel free to comment as well.

@jlucaso1 jlucaso1 force-pushed the feat-custom-logger-libsignal branch from 5219581 to 5fa65f6 Compare October 21, 2025 16:59
@jlucaso1 jlucaso1 force-pushed the feat-custom-logger-libsignal branch from 5fa65f6 to 9178973 Compare October 21, 2025 17:03
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

This PR is stale because it has been open for 14 days with no activity. Remove the stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the Stale label Nov 5, 2025
Copy link
Member

@purpshell purpshell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we can do some sort of libsignal.withLogger approach and import from that or something, I'm not sure. Well since the socket itself is taking in the logger, it becomes hard to pull something like .withLogger at the top of the code.

Since this is still a draft, please think of alternate ways of adding the logger without modifying function signatures. Maybe Curve.withLogger().verify. And the withLogger returns this after the logger has been added, and without the logger there is maybe a default logger or nothing. This way no breaking change is made.

@purpshell purpshell force-pushed the master branch 2 times, most recently from bd1c658 to f46e8b1 Compare November 21, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants