perf: reduce memory consumption #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- **Refactor Label Structure**: Updated the label structure from `Label` to `LabelCandidates` in `sample_generator.go`, `sample_loader.go`, `permutation.go`, and `permutation_test.go` to better represent label candidates. - **Optimize Time Series Generation**: Introduced streaming and goroutine-based time series generation in `sample_loader.go` to improve performance and scalability. - **Add Unit Tests**: Created `sample_loader_test.go` to test the new `TagSetPermutationStream` function, ensuring correct permutations of label candidates. Signed-off-by: Lei, HUANG <[email protected]>
Add database label support to `SampleLoader` - Introduced a new `Database` field in `SampleLoader` to store the database name. - Updated `run` method in `sample_loader.go` to retrieve the database name from command-line flags. - Modified `convertMetricToTimeSeries` and `generateTimeSeriesForFileConfig` methods to append the database name as a label to time series if specified. - Added a new command-line flag `--database` to specify the database name in `NewCommand`. Signed-off-by: Lei, HUANG <[email protected]>
WenyXu
approved these changes
Sep 25, 2025
Add database label support to `SampleLoader` - Introduced a new `Database` field in `SampleLoader` to store the database name. - Updated `run` method in `sample_loader.go` to retrieve the database name from command-line flags. - Modified `convertMetricToTimeSeries` and `generateTimeSeriesForFileConfig` methods to append the database name as a label to time series if specified. - Added a new command-line flag `--database` to specify the database name in `NewCommand`. Signed-off-by: Lei, HUANG <[email protected]>
- **Enhancements in `sample_loader.go`:** - Added logging for the number of series in each request sent by the worker. - **Updates in `distribution.go`:** - Introduced `NumCandidates` method to `LabelGenerator` interface and implemented it in `ConstantString` and `WeightedPreset` types. - **Improvements in `parse.go`:** - Added logging for the number of series parsed from each YAML file and the total series count. - Changed variable `name` to `metricName` for clarity. Signed-off-by: Lei, HUANG <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LabeltoLabelCandidatesinsample_generator.go,sample_loader.go,permutation.go, andpermutation_test.goto better represent label candidates.sample_loader.goto improve performance and scalability.sample_loader_test.goto test the newTagSetPermutationStreamfunction, ensuring correct permutations of label candidates.