Skip to content

fix: preserve existing settings during default init#2338

Open
imleoo wants to merge 1 commit intoWei-Shaw:mainfrom
imleoo:fix/settings-default-backfill
Open

fix: preserve existing settings during default init#2338
imleoo wants to merge 1 commit intoWei-Shaw:mainfrom
imleoo:fix/settings-default-backfill

Conversation

@imleoo
Copy link
Copy Markdown

@imleoo imleoo commented May 10, 2026

Summary

  • backfill missing default settings instead of using a single sentinel key
  • preserve existing database-backed settings during startup/default initialization
  • add unit coverage for partial settings backfills and existing value preservation

Tests

  • go test -tags=unit ./internal/service -run 'TestSettingService_InitializeDefaultSettings'
  • go test -tags=unit ./internal/service
  • git diff --check

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement (CLA).

To sign, please reply with the following comment:

I have read the CLA Document and I hereby sign the CLA

You only need to sign once — it will be valid for all your future contributions to this project.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant