Skip to content

fix(auth-cache): invalidate legacy image auth snapshots #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RYMH wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

fix(auth-cache): invalidate legacy image auth snapshots #2323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/internal/service/api_key_auth_cache_impl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
"github.com/dgraph-io/ristretto"
)

const apiKeyAuthSnapshotVersion = 9 // v9: added API Key name for audit logs
const apiKeyAuthSnapshotVersion = 10 // v10: invalidate legacy auth snapshots missing image-generation fields

type apiKeyAuthCacheConfig struct {
l1Size int
Expand Down
7 changes: 7 additions & 0 deletions backend/internal/service/api_key_service_cache_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,9 @@ func TestAPIKeyService_SnapshotRoundTrip_PreservesMessagesDispatchModelConfig(t
Status: StatusActive,
SubscriptionType: SubscriptionTypeStandard,
RateMultiplier: 1,
AllowImageGeneration: true,
ImageRateIndependent: true,
ImageRateMultiplier: 1.75,
AllowMessagesDispatch: true,
DefaultMappedModel: "gpt-5.4",
MessagesDispatchModelConfig: OpenAIMessagesDispatchModelConfig{
Expand All @@ -270,6 +273,9 @@ func TestAPIKeyService_SnapshotRoundTrip_PreservesMessagesDispatchModelConfig(t
require.NotNil(t, roundTrip)
require.Equal(t, apiKey.Name, roundTrip.Name)
require.NotNil(t, roundTrip.Group)
require.True(t, roundTrip.Group.AllowImageGeneration)
require.True(t, roundTrip.Group.ImageRateIndependent)
require.Equal(t, 1.75, roundTrip.Group.ImageRateMultiplier)
require.Equal(t, apiKey.Group.MessagesDispatchModelConfig, roundTrip.Group.MessagesDispatchModelConfig)
}

Expand Down Expand Up @@ -320,6 +326,7 @@ func TestAPIKeyService_GetByKey_IgnoresLegacyAuthCacheSnapshotWithoutMessagesDis
cache.getAuthCache = func(ctx context.Context, key string) (*APIKeyAuthCacheEntry, error) {
return &APIKeyAuthCacheEntry{
Snapshot: &APIKeyAuthSnapshot{
Version: apiKeyAuthSnapshotVersion - 1,
APIKeyID: 1,
UserID: 2,
GroupID: &groupID,
Expand Down
Loading