Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebGPU] CTS validation/render_pipeline/multisample_state.html is failing #22190

Merged
merged 1 commit into from
Jan 3, 2024
Merged

[WebGPU] CTS validation/render_pipeline/multisample_state.html is failing #22190

merged 1 commit into from
Jan 3, 2024

Conversation

mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented Dec 22, 2023 •
edited by webkit-early-warning-system
Loading

bb4e804

[WebGPU] CTS validation/render_pipeline/multisample_state.html is failing
https://bugs.webkit.org/show_bug.cgi?id=266735
<radar://119958299>

Reviewed by Tadeu Zagallo.

Add validation for multisample_state along with passing expectations.

* LayoutTests/http/tests/webgpu/webgpu/api/validation/render_pipeline/multisample_state-expected.txt:
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipeline):

Canonical link: https://commits.webkit.org/272622@main

e81c0b3

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski self-assigned this Dec 22, 2023
@mwyrzykowski mwyrzykowski added the WebGPU For bugs in WebGPU label Dec 22, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 22, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 590fe3b)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski changed the title [WebGPU] [WebGPU] CTS validation/render_pipeline/multisample_state.html is failing Dec 22, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 22, 2023
@mwyrzykowski mwyrzykowski removed the merging-blocked Applied to prevent a change from being merged label Dec 28, 2023
@mwyrzykowski mwyrzykowski force-pushed the eng/WebGPU_CTS_validation_render_pipeline_multisample_state_html_is_failing branch from 590fe3b to e81c0b3 Compare January 3, 2024 17:27
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 3, 2024 •
edited
Loading

EWS run on current version of this PR (hash e81c0b3)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jan 3, 2024
@webkit-ews-buildbot webkit-ews-buildbot removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jan 3, 2024
@mwyrzykowski mwyrzykowski added the merge-queue Applied to send a pull request to merge-queue label Jan 3, 2024
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #8144.

@mwyrzykowski mwyrzykowski added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Jan 3, 2024
@mwyrzykowski
[WebGPU] CTS validation/render_pipeline/multisample_state.html is fai…
bb4e804 
…ling

https://bugs.webkit.org/show_bug.cgi?id=266735
<radar://119958299>

Reviewed by Tadeu Zagallo.

Add validation for multisample_state along with passing expectations.

* LayoutTests/http/tests/webgpu/webgpu/api/validation/render_pipeline/multisample_state-expected.txt:
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipeline):

Canonical link: https://commits.webkit.org/272622@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU_CTS_validation_render_pipeline_multisample_state_html_is_failing branch from e81c0b3 to bb4e804 Compare January 3, 2024 20:36
@webkit-commit-queue
Copy link
Collaborator

Committed 272622@main (bb4e804): https://commits.webkit.org/272622@main

Reviewed commits have been landed. Closing PR #22190 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit bb4e804 into WebKit:main Jan 3, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeuzagallo tadeuzagallo tadeuzagallo approved these changes

@djg djg Awaiting requested review from djg

Assignees

@mwyrzykowski mwyrzykowski

Labels
WebGPU For bugs in WebGPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mwyrzykowski @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @tadeuzagallo