Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/3.1 - merge 471 (news site remove useEffect) #475

Merged

Conversation

flashdesignory
Copy link
Contributor

@flashdesignory flashdesignory commented Jan 27, 2025

For reference: fix for main can be found here: #471

Crossbench:

Screenshot 2025-01-27 at 9 52 05 AM

@flashdesignory flashdesignory marked this pull request as draft January 27, 2025 14:20
@julienw
Copy link
Contributor

julienw commented Jan 27, 2025

looks good to me, but I'm not sure if I should review formally because it's still draft.

@flashdesignory
Copy link
Contributor Author

looks good to me, but I'm not sure if I should review formally because it's still draft.

It's just draft, because I need a release/3.1 branch to merge it into.

@flashdesignory flashdesignory changed the base branch from release/3.0 to release/3.1 January 28, 2025 17:45
@flashdesignory flashdesignory marked this pull request as ready for review January 28, 2025 17:46
@flashdesignory flashdesignory changed the title WIP: changes from 471 applied to 3.0 Changes from 471 applied to 3.0 Jan 28, 2025
@flashdesignory flashdesignory changed the title Changes from 471 applied to 3.0 Release/3.1 - merge 471 (news site remove useEffect) Jan 29, 2025
@lutzvahl lutzvahl added the v3.1 label Jan 29, 2025
@flashdesignory flashdesignory merged commit e971009 into WebKit:release/3.1 Jan 29, 2025
@flashdesignory flashdesignory deleted the release/3.1-news-next branch January 29, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants