Convert gcc-loops-wasm to JS-style scoring #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build with the same options (-O2, Emscripten MODULARIZE, etc.) as TSF-wasm before. Use the WasmEMCCBenchmark class introduced earlier. Since we want to run multiple iterations (for first, average, worst scoring), change to small workload size. Each individual iteration still runs >20ms, which we agreed on in the last sync. Drive-by fixes: The WasmEMCCBenchmark setup code needs to make sure we don't automatically run main() after setupModule(). The TSF-wasm build script uses `set -o pipefail`, which is a bash option, hence change shebang line. Add Wall time output also for WasmEMCCBenchmark and WasmLegacyBenchmark.
danleh
commented
Jan 15, 2025
| it can accommodate n elements such that n = vector-size/element-size | ||
| (e.g, 4 ints, 8 shorts, or 16 chars for a vector of size 16 bytes). | ||
| A combination of data-types of different sizes in the same loop | ||
| Currently only a single vector-size per target is supported; |
There was a problem hiding this comment.
Whitespace changes, automatically truncated by VS code.
danleh
commented
Jan 15, 2025
danleh
commented
Jan 15, 2025
danleh
commented
Jan 15, 2025
danleh
commented
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build with the same options (-O2, Emscripten
-s MODULARIZE, etc.) astsf-wasmbefore. Use theWasmEMCCBenchmarkclass introduced earlier. Since we want to run multiple iterations (for first, average, worst scoring), change to small workload size. Each individual iteration still runs >20ms, which we agreed on in the last sync.Drive-by fixes:
The
WasmEMCCBenchmarksetup code needs to make sure we don't automatically runmain()aftersetupModule(), hence addnoInitialRun. The TSF-wasm build script usesset -o pipefail, which is a bash option, hence change shebang line. Add Wall time output also forWasmLegacyBenchmark.I compared profiles/flamegraphs before and after the recompilation of
gcc-loops.wasm. We still spend the vast majority of the CPU samples in top-tier compiled code, which makes sense.