Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly use BenchmarkClass #13

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Directly use BenchmarkClass #13

wants to merge 4 commits into from
+188 −208

Conversation

camillobruni
Copy link
Contributor

  • Avoid the plan.benchmarkClass and directly use the dedicated BenchmarkClass and get some free pre-validation.
  • Pull out the fetchResources() call from the BenchmarkClass constructor

@camillobruni camillobruni mentioned this pull request Nov 26, 2024
Open
kmiller68
kmiller68 reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@kmiller68 kmiller68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems fine although I think you have a bug. This also needs another rebase (sorry).

JetStreamDriver.js
Comment on lines +694 to 695
const tries = 3;
while (tries--) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups... definitely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmiller68 kmiller68 kmiller68 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camillobruni @kmiller68