Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use algorithmic style more #144

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Use algorithmic style more #144

merged 2 commits into from
Feb 28, 2025

Conversation

padenot
Copy link
Member

@padenot padenot commented Feb 21, 2025

Related to #142

@beaufortfrancois had done some work, I cleaned it up. This is far from finished, we need a state machine, because we can't do things like:

1. If {{[[started]]}} is `true` and no <a event
     for=SpeechRecognition>error</a> or <a event for=SpeechRecognition>end</a> event
     have fired, throw an {{InvalidStateError}} and abort these steps.

instead we need to have a [[state]] (that could be "ended", "error", etc.) and check it.


Preview | Diff

@beaufortfrancois
Copy link
Contributor

LGTM

@evanbliu
Copy link
Collaborator

LGTM!

@padenot
Copy link
Member Author

padenot commented Feb 28, 2025

Fixed the validator thing, I'll merge now, thanks for the reviews!

@padenot padenot marked this pull request as ready for review February 28, 2025 14:01
@padenot padenot merged commit c0694cb into main Feb 28, 2025
1 check passed
github-actions bot added a commit that referenced this pull request Feb 28, 2025
SHA: c0694cb
Reason: push, by padenot

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants