- 
                Notifications
    You must be signed in to change notification settings 
- Fork 38
Update the on-device speech recognition methods #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @padenot - Can you please take a look at this PR when you get a chance? Thanks! | 
| Sorry to be picky, but I think it's good to get things right from the get-go to get the ball rolling on the first few PRs. Apart from the "when do we know downloading has finished", my comments are on the form rather than the substance of the PR, but unfortunately that matters in normative writing. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way better, still some comments.
How does one know that the model has finished downloaded?
| 
 From above: What are your thoughts on either: 
 | 
This CL updates the return type of the availableOnDevice API to reflect the spec changes in this PR: github.com/WebAudio/web-speech-api/pull/143 Bug:40286514 Change-Id: I66e4a18e5cdaf262cecd847eca6b2205618028ef
| FYI https://github.com/webmachinelearning/prompt-api?tab=readme-ov-file#download-progress may be of interest for this group. | 
This CL updates the return type of the availableOnDevice API to reflect the spec changes in this PR: github.com/WebAudio/web-speech-api/pull/143 Bug: 40286514 Change-Id: I66e4a18e5cdaf262cecd847eca6b2205618028ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299973 Reviewed-by: Tom Sepez <[email protected]> Commit-Queue: Evan Liu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1429100}
This CL updates the return type of the availableOnDevice API to reflect the spec changes in this PR: github.com/WebAudio/web-speech-api/pull/143 Bug: 40286514 Change-Id: I66e4a18e5cdaf262cecd847eca6b2205618028ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299973 Reviewed-by: Tom Sepez <[email protected]> Commit-Queue: Evan Liu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1429100}
This CL updates the return type of the availableOnDevice API to reflect the spec changes in this PR: github.com/WebAudio/web-speech-api/pull/143 Bug: 40286514 Change-Id: I66e4a18e5cdaf262cecd847eca6b2205618028ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299973 Reviewed-by: Tom Sepez <[email protected]> Commit-Queue: Evan Liu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1429100}
…API, a=testonly Automatic update from web-platform-tests Update return type of availableOnDevice API This CL updates the return type of the availableOnDevice API to reflect the spec changes in this PR: github.com/WebAudio/web-speech-api/pull/143 Bug: 40286514 Change-Id: I66e4a18e5cdaf262cecd847eca6b2205618028ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299973 Reviewed-by: Tom Sepez <[email protected]> Commit-Queue: Evan Liu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1429100} -- wpt-commits: 95c04e58fe733a0e93682aa2c7dd1dc37913c1b8 wpt-pr: 51148
…API, a=testonly Automatic update from web-platform-tests Update return type of availableOnDevice API This CL updates the return type of the availableOnDevice API to reflect the spec changes in this PR: github.com/WebAudio/web-speech-api/pull/143 Bug: 40286514 Change-Id: I66e4a18e5cdaf262cecd847eca6b2205618028ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299973 Reviewed-by: Tom Sepez <[email protected]> Commit-Queue: Evan Liu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1429100} -- wpt-commits: 95c04e58fe733a0e93682aa2c7dd1dc37913c1b8 wpt-pr: 51148
| Gentle ping -- @padenot - Do you have any additional comments on this CL, or on how the API for detecting if the download has finished should look like? | 
| 
 I'd like to propose option 3: update installOnDevice to resolve to true once on-device speech recognition is installed rather than resolving to true when the installation is initiated. The Promise will resolve to false if the download fails for any reason (i.e. user rejects the download, network issues, unsupported language) and resolve to true once the language is installed and ready. I don't think the delay should be much of an issue because in most cases the download would complete relatively quickly. Of course, there will be some cases in which the download takes much longer, but the current installOnDevice API could also take a long time to resolve to True if the user takes awhile to respond to a prompt, so websites will need to handle this delay already anyways. | 
| Yes, I'd tend to agree. We could imagine having a UA-side progress indicator here. | 
| Sounds good, I've updated the spec to reflect this. Let me know if you have any other comments or concerns on this PR! | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some comments, but nothing too important. If the answer to the last sentence of the 3rd comment is yes, this is good for merging w/ the small adjustment I mentioned.
SHA: bad1722 Reason: push, by evanbliu Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: bad1722 Reason: push, by evanbliu Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…API, a=testonly Automatic update from web-platform-tests Update return type of availableOnDevice API This CL updates the return type of the availableOnDevice API to reflect the spec changes in this PR: github.com/WebAudio/web-speech-api/pull/143 Bug: 40286514 Change-Id: I66e4a18e5cdaf262cecd847eca6b2205618028ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299973 Reviewed-by: Tom Sepez <[email protected]> Commit-Queue: Evan Liu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1429100} -- wpt-commits: 95c04e58fe733a0e93682aa2c7dd1dc37913c1b8 wpt-pr: 51148
Closes #141
This PR contains the following changes:
Preview | Diff