Update the on-device speech recognition methods #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@padenot - Can you please take a look at this PR when you get a chance? Thanks! |
padenot
requested changes
Feb 28, 2025
index.bs
Outdated
| 1. If the on-device speech recognition language pack for <var>lang</var> is unsupported, return {{AvailabilityStatus/unavailable}}. | ||
| 1. If the on-device speech recognition language pack for <var>lang</var> is supported but not installed, return {{AvailabilityStatus/downloadable}}. | ||
| 1. If the on-device speech recognition language pack for <var>lang</var> is downloading, return {{AvailabilityStatus/downloading}}. | ||
| 1. If the on-device speech recognition language pack for <var>lang</var> is installed, return {{AvailabilityStatus/available}}. |
There was a problem hiding this comment.
When do we know it has finished downloading?
|
Sorry to be picky, but I think it's good to get things right from the get-go to get the ball rolling on the first few PRs. Apart from the "when do we know downloading has finished", my comments are on the form rather than the substance of the PR, but unfortunately that matters in normative writing. |
padenot
requested changes
Mar 5, 2025
From above: What are your thoughts on either:
|
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 5, 2025
This CL updates the return type of the availableOnDevice API to reflect the spec changes in this PR: github.com/WebAudio/web-speech-api/pull/143 Bug:40286514 Change-Id: I66e4a18e5cdaf262cecd847eca6b2205618028ef
|
FYI https://github.com/webmachinelearning/prompt-api?tab=readme-ov-file#download-progress may be of interest for this group. |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Mar 6, 2025
This CL updates the return type of the availableOnDevice API to reflect the spec changes in this PR: github.com/WebAudio/web-speech-api/pull/143 Bug: 40286514 Change-Id: I66e4a18e5cdaf262cecd847eca6b2205618028ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299973 Reviewed-by: Tom Sepez <[email protected]> Commit-Queue: Evan Liu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1429100}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 6, 2025
This CL updates the return type of the availableOnDevice API to reflect the spec changes in this PR: github.com/WebAudio/web-speech-api/pull/143 Bug: 40286514 Change-Id: I66e4a18e5cdaf262cecd847eca6b2205618028ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299973 Reviewed-by: Tom Sepez <[email protected]> Commit-Queue: Evan Liu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1429100}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 6, 2025
This CL updates the return type of the availableOnDevice API to reflect the spec changes in this PR: github.com/WebAudio/web-speech-api/pull/143 Bug: 40286514 Change-Id: I66e4a18e5cdaf262cecd847eca6b2205618028ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299973 Reviewed-by: Tom Sepez <[email protected]> Commit-Queue: Evan Liu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1429100}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #141
This PR contains the following changes:
Preview | Diff