-
Notifications
You must be signed in to change notification settings - Fork 172
Throw onerror instead of exception for AudioContext constructor #2629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hoch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is what we discussed offline, but I am curious if there are places we might need to spot check,
|
Thank you for the quick review! I'm not sure if this is the best way to word this change, so any feedback or additional checking is welcome. |
padenot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small non-fonctional comment.
|
After the working group meeting this PR needs some rework, I will comment again when it is ready for review. |
|
I think the current patch covers what we talked about at the meeting:
I'm not sure about the naming of the private slot, and we also have two things called sending a control message to start processing (one in the constructor and one for setsinkid) but hopefully it's clear from context which one is which. |
This affects #2435, but may not fix everything in that issue.
We discussed at TPAC 2024 that, because device enumeration is asynchronous, it will be easier for implementers and also more robust to use onerror to signal problems with the device at construction time.
This PR does the following:
Preview | Diff