Implement GC basics #2607
Draft
Implement GC basics #2607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 22, 2025 04:42
Support named references for globals, locals, tables, elems Support named references for call_ref, ref_null Extend Var variables with an optional type field
zherczeg
force-pushed
the
gc_core
branch
2 times, most recently
from
243ec44 to
68fe37e
Compare
zherczeg
commented
May 23, 2025
| struct TypeMut { | ||
| Type type; | ||
| bool mutable_; | ||
| }; | ||
| using TypeMutVector = std::vector<TypeMut>; | ||
|
|
||
| // Garbage Collector specific type information |
There was a problem hiding this comment.
This is a core part of the patch. It contains the (sub ...) part of the type. It is declared as a structure, because it is not mandatory.
include/wabt/binary-reader.h
Outdated
| virtual Result OnFuncType(Index index, | ||
| GCTypeExtension* gc_ext, |
There was a problem hiding this comment.
This structure is passed as a second argument, because it is a header, but it could go to the last argument since it is an extra (and optional) information. Which one you prefer?
| struct RecursiveRange { | ||
| Index start_index; | ||
| Index type_count; | ||
| }; |
There was a problem hiding this comment.
This is another core structure to encode (rec ...) constructs. It represents the range.
include/wabt/type-checker.h
Outdated
| std::vector<FuncType> func_types; | ||
| std::vector<StructType> struct_types; | ||
| std::vector<ArrayType> array_types; | ||
| std::vector<RecursiveRange> recursive_ranges; |
There was a problem hiding this comment.
It is stored in an ordered array. It cannot be stored as part of the types, because zero length (rec) range is allowed for whatever reason.
zherczeg
force-pushed
the
gc_core
branch
2 times, most recently
from
5ddddbc to
0de3728
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing / reading / writing of core structures (rec/sub) is mostly completed, validation is far from over