[Custom Descriptors] Interpret descriptor casts #7677
Merged
+299
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Descriptor casts must check that the expected descriptor is not null, check whether the cast value is null, and if so, whether the cast allows null values through, and finally must check whether the descriptor on a non-null cast value matches the expected descriptor. This is fairly different than the implementation of a normal cast, but the possible results are the same. Add a new `doDescCast` helper mirroring the existing `doCast` helper and use it to implement the various descriptor casts.
kripken
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptor casts must check that the expected descriptor is not null,
check whether the cast value is null, and if so, whether the cast allows
null values through, and finally must check whether the descriptor on
a non-null cast value matches the expected descriptor. This is fairly
different than the implementation of a normal cast, but the possible
results are the same. Add a new
doDescCasthelper mirroring theexisting
doCasthelper and use it to implement the various descriptorcasts.