Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the reference link #217

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fix the reference link #217

merged 1 commit into from
Feb 26, 2024

Conversation

hankluo6
Copy link
Contributor

Explanation

The PR fixes the incorrect link in the plugin documentation.

What type of PR is this

/kind documentation

Signed-off-by: hankluo6 <[email protected]>
Copy link
Collaborator

alabulei1 commented Feb 25, 2024

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit efd07ac5cd0fd43b4abde7f9e42d90272f9e6063

Key changes:

  1. Updated the reference link in the rusttls.md file to point to the correct GitHub repository.
  2. Updated the reference link in the wasi_crypto.md file to point to the correct GitHub repository.

Potential problems:

  1. In the rusttls.md file, the reference link was updated correctly to point to the wasmedge_rustls repository. This seems to be a straightforward fix with no apparent issues.
  2. In the wasi_crypto.md file, the reference link was updated correctly to point to the wasi_crypto repository. This also appears to be a straightforward fix with no apparent issues.

Overall, the proposed changes seem to be correct and consistent with updating the reference links to the correct GitHub repositories for both plugins. The patch appears to address the issue of fixing the reference links effectively.

@alabulei1
Copy link
Collaborator

Nice catch! Thank you so much!

@alabulei1 alabulei1 merged commit f166bad into WasmEdge:main Feb 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants